- This removes an inline event handler
- This also adds an aria-label
Using javascript instead of just using <a></a> is bad practice regarding accessibility and automated processing of web pages. Even the browser doesn't show a hint if hovering badges when using the old implementation. This in my opinion is a good way to replace inline event handlers in that code.
This fixes the following issue in Chrome: No label associated with a form field.
I don't know why a <label> was used here before, but I see no reason to do so, a div works just as well.
This fixes https://github.com/nunocoracao/blowfish/issues/2292 and avoids expanding in weird ways on larger screens.
It does make the section a larger on large screens. This however looks reasonable and should actually be an improvement.
For consistency I added w-full to layouts unaffected by https://github.com/nunocoracao/blowfish/issues/2292 too (page, card). Otherwise they look off.
page layout still has a bug where the fixed-width div expands the section too much on larger screens, but this behavior is the same as before. All layouts do not encounter https://github.com/nunocoracao/blowfish/issues/2292.
Fixed width elements were overflowing previously on:
background, hero and profile.
This addresses https://github.com/nunocoracao/blowfish/issues/2292
Currently the section element expands more than it used to
on larger screens, I will try to fix this.
If MDN explicitly warns user not to use them, we probably shouldn't.
MDN also states: "Note that inline event handlers are blocked as well[...]You should replace them with addEventListener calls[...]" regarding CSP.
This renames $youtubeLiteJS $youtubeLiteLib to match the naming of other files in assets/lib and moves the initialization of $youtubeLiteLib to the bottom, above the script element
This also adds 3 missing fingerprints, one to $packeryLib, one to $twelementsLib and one to $youtubeLiteCSS
I couldn't find any reason why this plugin is in package.json but not in .prettierrc. Also no issues/PRs etc.
Auto formatting with this hasn't been added or tested for accuracy yet (only for functionality), but I assume that if the plugin is in package.json, it should actually get used by prettier.
I'm not sure why this is such a big problem, but hugo doesn't seem to like this. It is also better to just use the intended way to reassign vars always.
Before, *feature* images if using background.html would always get overwritten, now that is fixed.
This greatly reduces the number of inline styles in the project and enhances maintainability by avoiding a lot of duplicate code.
This also reduces the number of hashes required for a CSP since all previous background-image inline styles are now in main.css.
This improves readability and removes an unnecessary function declaration by using IIFE.
This is inspired by https://github.com/nunocoracao/blowfish/pull/2262 . If both are merged, this would enhance consistency
- Move out of line by using already defined css classes
- Move paddings out of line
- Move margins out of line
- Move z-indexes out of line
- Move center-relative-left out of line
Served Smart